Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing overlay layout to a single column #2127

Merged
merged 1 commit into from
Sep 22, 2017
Merged

Changing overlay layout to a single column #2127

merged 1 commit into from
Sep 22, 2017

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Sep 20, 2017

@rhamilto rhamilto changed the title [WIP] Changing overlay layout to a single column Changing overlay layout to a single column Sep 21, 2017
@rhamilto rhamilto changed the title Changing overlay layout to a single column [WIP] Changing overlay layout to a single column Sep 21, 2017
@@ -0,0 +1,20 @@
<div class="order-service-details" ng-if="!$ctrl.selectStep.selected">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the ng-if is needed here because you check ng-if="step.selected" above before including the view.

<div class="order-service-details" ng-if="!$ctrl.selectStep.selected">
<div class="order-service-details-top">
<div class="service-icon">
<span class="icon {{$ctrl.iconClass}}"></span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aria-hidden="true"

@rhamilto rhamilto changed the title [WIP] Changing overlay layout to a single column Changing overlay layout to a single column Sep 22, 2017
@spadgett spadgett added this to the 3.7.0 milestone Sep 22, 2017
@spadgett
Copy link
Member

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to e3af4f7

@openshift-bot
Copy link

openshift-bot commented Sep 22, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/249/) (Base Commit: 0ffc72d) (PR Branch Commit: e3af4f7)

@openshift-bot openshift-bot merged commit d8fc250 into openshift:master Sep 22, 2017
@rhamilto rhamilto deleted the single-column-overlay branch September 22, 2017 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants